test-improvement-6017: Rspec/ContextWording task grouped by ecosystem. #9758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
approved these changes
May 17, 2024
added 4 commits
May 17, 2024 16:05
…with shared_context.
thavaahariharangit
force-pushed
the
harry/test-improvement-6017
branch
from
6401cfa
to
3294c09
Compare
jurre
reviewed
May 17, 2024
| @@ -35,7 +35,7 @@ | |||
| let(:gemfile) { bundler_project_dependency_file("path_source", filename: "Gemfile") } | |||
| it { is_expected.to eq([Pathname.new("plugins/example")]) } | |||
|
|
|||
| context "whose path must be eval-ed" do | |||
| context "when the path must be eval-ed" do | |||
There was a problem hiding this comment.
The broader context here is:
when the file does include a path gemspec when the path must be eval-ed
Maybe this would be nicer?
when the file does include a path gemspec with a path that must be eval-ed
jurre
reviewed
May 17, 2024
| @@ -65,7 +65,7 @@ | |||
| end | |||
There was a problem hiding this comment.
I don't love how this reads, I would suggest removing the nesting here:
context "with a file that does include a relative path" do
# ...
context "when it needs to be evaled" do
let(:file_body) do
'require_relative "./my_file_#{raise %(hell)}"'
end
it { is_expected.to eq([]) }
end
context "when it can't be evaled" do
let(:file_body) do
'require_relative "./my_file_#{unknown_var}"'
end
it { is_expected.to eq([]) }
end
jurre
reviewed
May 17, 2024
| @@ -77,7 +77,7 @@ | |||
| .to match_array(%w(Gemfile Gemfile.lock .ruby-version)) | |||
| end | |||
|
|
|||
| context "that can't be found" do | |||
| context "when that can't be found" do | |||
There was a problem hiding this comment.
with a directory when that can't be found
This isn't a great sentence
jurre
reviewed
May 17, 2024
| @@ -93,7 +93,7 @@ | |||
| end | |||
| end | |||
|
|
|||
| context "that returns a file" do | |||
| context "when that returns a file" do | |||
There was a problem hiding this comment.
with a directory when that returns a file
Also not a great sentence
jurre
reviewed
May 17, 2024
| @@ -233,7 +233,7 @@ | |||
| ) | |||
| end | |||
|
|
|||
| context "that has a fetchable path" do | |||
| context "when that has a fetchable path" do | |||
jurre
reviewed
May 17, 2024
| @@ -279,7 +279,7 @@ | |||
| ) | |||
| end | |||
|
|
|||
| context "that has a fetchable path" do | |||
| context "when that has a fetchable path" do | |||
There was a problem hiding this comment.
Also not a great sentence in the context
thavaahariharangit
added a commit
that referenced
this pull request
May 24, 2024
…w comments of #9758 addressed here. (#9782) * TICtxtWrd-bundler: Test Improvement, Context Wording, ecosystem bundler. * TICtxtWrd-bundler: Test Improvement, Context Wording, ecosystem bundler. * TICtxtWrd-bundler: Test Improvement, Context Wording, ecosystem bundler. * TICtxtWrd-bundler: Test Improvement, Context Wording, ecosystem bundler. * TICtxtWrd-bundler: Rebasing main. * TICtxtWrd-bundler: Test Improvement, Context Wording, ecosystem bundler. * TICtxtWrd-bundler: Fixing with code spell error. * TICtxtWrd-bundler:Fixing the codespell error. * TICtxtWrd-bundler: Fixing the lint errors. --------- Co-authored-by: “Thavachelvam <“thavaahariharangit@git.com”>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grouping Rspec/ContextWording task by ecosystem.