Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lowest_prerelease_suffix method #10832

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

amazimbe
Copy link
Contributor

What are you trying to accomplish?

I need to be able to get the correct lowest prerelease suffix for a version. I can then use this to build the correct version ignore ranges in dependabot core as well as dependabot API.

Currently, we have this suffix hardcoded in a few areas of the core codebase and api codebase . Unfortunately, this suffix is ecosystem-specific and that's why this PR adds a method to return the correct suffix in a specific ecosystem.

Once this PR get's merged I can then fix this issue. There is already a draft PR for that here

Anything you want to highlight for special attention from reviewers?

It is a bit cleaner rather than checking class names. For example:

suffix = "a0" if version.is_a? Dependabot::Maven::Version

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@amazimbe amazimbe self-assigned this Oct 22, 2024
@github-actions github-actions bot added L: java:maven Maven packages via Maven L: python labels Oct 22, 2024
@amazimbe amazimbe marked this pull request as ready for review October 22, 2024 15:35
@amazimbe amazimbe requested a review from a team as a code owner October 22, 2024 15:35
@amazimbe amazimbe force-pushed the amazimbe/lowest-prerelease-prefix branch from bcacd95 to 7d1d4cd Compare October 22, 2024 15:35
@amazimbe amazimbe force-pushed the amazimbe/lowest-prerelease-prefix branch from 7d1d4cd to 370c981 Compare October 23, 2024 14:46
@amazimbe amazimbe merged commit 8afbd08 into main Oct 23, 2024
123 checks passed
@amazimbe amazimbe deleted the amazimbe/lowest-prerelease-prefix branch October 23, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: java:maven Maven packages via Maven L: python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants