Add lowest_prerelease_suffix method #10832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
I need to be able to get the correct lowest prerelease suffix for a version. I can then use this to build the correct version ignore ranges in dependabot core as well as dependabot API.
Currently, we have this suffix hardcoded in a few areas of the core codebase and api codebase . Unfortunately, this suffix is ecosystem-specific and that's why this PR adds a method to return the correct suffix in a specific ecosystem.
Once this PR get's merged I can then fix this issue. There is already a draft PR for that here
Anything you want to highlight for special attention from reviewers?
It is a bit cleaner rather than checking class names. For example:
suffix = "a0" if version.is_a? Dependabot::Maven::Version
How will you know you've accomplished your goal?
Checklist