Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignores not being applied for Cargo #6802

Open
1 task done
iajoiner opened this issue Mar 8, 2023 · 2 comments
Open
1 task done

Ignores not being applied for Cargo #6802

iajoiner opened this issue Mar 8, 2023 · 2 comments
Labels
F: dependency-ignores Allow excluding certain versions L: rust:cargo Rust crates via cargo T: bug 🐞 Something isn't working

Comments

@iajoiner
Copy link
Contributor

iajoiner commented Mar 8, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

cargo

Package manager version

cargo 1.67.1

Language version

Rust 1.67.1

Manifest location and content before the Dependabot update

https://github.com/apache/arrow-ballista-python/blob/main/Cargo.toml

dependabot.yml content

https://github.com/apache/arrow-ballista-python/blob/main/.github/dependabot.yml

Updated dependency

datafusion 18.0.0 -> 19.0.0

What you expected to see, versus what you actually saw

It should have been ignored.

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

No response

Smallest manifest that reproduces the issue

No response

@iajoiner iajoiner added the T: bug 🐞 Something isn't working label Mar 8, 2023
@iajoiner
Copy link
Contributor Author

iajoiner commented Mar 8, 2023

This is true in multiple repos such as arrow-ballista, arrow-ballista-python and delta-rs. For some reason the ignored dependencies are not actually ignored.

@jeffwidman jeffwidman added the L: rust:cargo Rust crates via cargo label Mar 8, 2023
@jeffwidman jeffwidman changed the title Dependabot doesn't really ignore what it is supposed to ignore Ignores not being applied for Cargo Mar 8, 2023
@jeffwidman jeffwidman added the F: dependency-ignores Allow excluding certain versions label Mar 8, 2023
@jeffwidman
Copy link
Member

Oof, that's got to be frustrating.

I wish I could say I've got time to dive into this right now, but reality is that may not happen for a bit due to some of the other larger improvements we've got in flight.

In the meantime you are welcome to use the dry-run script to investigate further. It should be relatively straightforward, just run it within the docker container (see the linked docs), and sprinkle debugger / puts statements through the code as needed to try to track down what's happening.

If you are able to zero in on the problem a bit further, that'd certainly be helpful for whenever we do have time to pick this up...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: dependency-ignores Allow excluding certain versions L: rust:cargo Rust crates via cargo T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants