Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the widen strategy for Python #6630

Open
deivid-rodriguez opened this issue Feb 9, 2023 · 4 comments
Open

Enable the widen strategy for Python #6630

deivid-rodriguez opened this issue Feb 9, 2023 · 4 comments
Assignees
Labels
F: configuration-file L: python:pip Python packages via pip L:python:pip-compile Python packages via pip-compile L: python:pipenv Python packages via pipenv L: python:poetry Python packages via poetry service 💁 Relates to Dependabot features GitHub provides

Comments

@deivid-rodriguez
Copy link
Contributor

deivid-rodriguez commented Feb 9, 2023

The service currently does not accept that users configure the widen strategy in their configuration file.

However, we do have widen support in Python, since it's the default strategy used for libraries.

There may be some issues, but we should accept it, so that users are free to try it out and experiment what strategy works best for their case. Docs at https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#versioning-strategy would also need to be updated.

Noticed at #6625 (comment).

@deivid-rodriguez deivid-rodriguez added L: python:pip Python packages via pip L: python:poetry Python packages via poetry service 💁 Relates to Dependabot features GitHub provides F: configuration-file L: python:pipenv Python packages via pipenv L:python:pip-compile Python packages via pip-compile labels Feb 9, 2023
@jeffwidman
Copy link
Member

It looks like #6632 fixes this, but you didn't cross-link it... does it only fix a subset for some reason?

@deivid-rodriguez
Copy link
Contributor Author

The widen is strategy is supported by dependabot-core (at least partially, and better with #6632). However, it's not yet enabled at the service level.

We need to make internal changes to start accepting explicit versioning-strategy: widen for Python in .dependabot.yml. Currently the widen strategy only gets used for Python libraries because it's the default, but users cannot opt into it explicitly.

@phillipuniverse
Copy link
Contributor

phillipuniverse commented Jun 9, 2023

Currently the widen strategy only gets used for Python libraries because it's the default, but users cannot opt into it explicitly.

@deivid-rodriguez does Dependabot make the determination of a Python project being a "service" an application or a "library"?

@deivid-rodriguez
Copy link
Contributor Author

We try to differentiate between "application" and "library", but I'm not sure that makes sense in the Python ecosystem, and we may stop doing that. See #6685.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: configuration-file L: python:pip Python packages via pip L:python:pip-compile Python packages via pip-compile L: python:pipenv Python packages via pipenv L: python:poetry Python packages via poetry service 💁 Relates to Dependabot features GitHub provides
Projects
None yet
Development

No branches or pull requests

4 participants