Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove / fix remaining hardcoded branch references to "master" #6202

Open
jeffwidman opened this issue Nov 23, 2022 · 0 comments · May be fixed by #7131
Open

Remove / fix remaining hardcoded branch references to "master" #6202

jeffwidman opened this issue Nov 23, 2022 · 0 comments · May be fixed by #7131
Assignees
@jeffwidman
Labels
EE Engineering Efficiency T: tech-debt ⚙️

Comments

@jeffwidman
Copy link
Member

jeffwidman commented Nov 23, 2022 •
edited
Loading

#6149 got me curious, and indeed we have two more places we hardcode a reference to "master":

dependabot-core/npm_and_yarn/lib/dependabot/npm_and_yarn/file_parser.rb

Line 289 in 0ac4e37

ref: details["ref"] || "master"

dependabot-core/hex/helpers/lib/parse_deps.exs

Line 96 in 0ac4e37

branch: opts[:branch] || "master",

These are the only two remaining hardcodings that I found.

We should fix those to fallback to the default branch, which may not be "master".

Related fix:
@abdulapopoola abdulapopoola added the EE Engineering Efficiency label Mar 30, 2023
@abdulapopoola abdulapopoola moved this to Next in Dependabot Mar 30, 2023
@jeffwidman jeffwidman linked a pull request Apr 21, 2023 that will close this issue
Open
@jeffwidman jeffwidman moved this from Next to In Progress in Dependabot Apr 21, 2023
@jeffwidman jeffwidman self-assigned this Apr 21, 2023
@abdulapopoola abdulapopoola removed the status in Dependabot Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffwidman jeffwidman

Labels
EE Engineering Efficiency T: tech-debt ⚙️
Projects
Dependabot
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove two more hardcoded master references dependabot/dependabot-core
2 participants
@jeffwidman @abdulapopoola