Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve update operation when both PackageReference and packages.config are present #10394

Open
brettfo opened this issue Aug 8, 2024 · 1 comment
Open

improve update operation when both PackageReference and packages.config are present #10394

brettfo opened this issue Aug 8, 2024 · 1 comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet

Comments

@brettfo
Copy link
Contributor

brettfo commented Aug 8, 2024

Some repos found in the wild reference packages via both <PackageReference> elements and packages.config. In this scenario, the updater sees a packages.config scenario and only goes down that path. The end result can be that we mistakenly add a reference to packages.config when we really should have updated a <PackageReference element, instead.

The proper behavior should be: if packages.config is present AND THAT FILE CONTAINS THE REFERENCE, then update with NuGet CLI; otherwise attempt an SDK package upgrade.
@brettfo brettfo added the L: dotnet:nuget NuGet packages via nuget or dotnet label Aug 8, 2024
@github-actions github-actions bot added the L: go:modules Golang modules label Aug 8, 2024
@brettfo brettfo removed the L: go:modules Golang modules label Aug 8, 2024
@cpowers534at
Copy link

This also can go the other way where it updates PackageReference and misses packages.config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
Dependabot
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettfo @cpowers534at