From 96e284036d3db87039acfd60169c53aa54c3ab5d Mon Sep 17 00:00:00 2001 From: Kamil Bukum Date: Mon, 21 Oct 2024 15:38:16 -0700 Subject: [PATCH] removed unused unsupported_versions. --- common/lib/dependabot/package_manager.rb | 17 +++++-- .../spec/dependabot/package_manager_spec.rb | 48 ++++++------------- 2 files changed, 28 insertions(+), 37 deletions(-) diff --git a/common/lib/dependabot/package_manager.rb b/common/lib/dependabot/package_manager.rb index 447bc3bf9cd..718ac712324 100644 --- a/common/lib/dependabot/package_manager.rb +++ b/common/lib/dependabot/package_manager.rb @@ -17,10 +17,21 @@ class PackageManagerBase # @param deprecated_versions [Array] an array of deprecated versions. # @param supported_versions [Array] an array of supported versions. sig do - params(ecosystem: String, name: String, version: Dependabot::Version, - deprecated_versions: T::Array[Dependabot::Version], supported_versions: T::Array[Dependabot::Version]).void + params( + ecosystem: String, + name: String, + version: Dependabot::Version, + deprecated_versions: T::Array[Dependabot::Version], + supported_versions: T::Array[Dependabot::Version] + ).void end - def initialize(ecosystem, name, version, deprecated_versions = [], supported_versions = []) + def initialize( + ecosystem, + name, + version, + deprecated_versions = [], + supported_versions = [] + ) @ecosystem = T.let(ecosystem, String) @name = T.let(name, String) @version = T.let(version, Dependabot::Version) diff --git a/common/spec/dependabot/package_manager_spec.rb b/common/spec/dependabot/package_manager_spec.rb index 8e265514320..e56f0cd834c 100644 --- a/common/spec/dependabot/package_manager_spec.rb +++ b/common/spec/dependabot/package_manager_spec.rb @@ -7,24 +7,14 @@ RSpec.describe Dependabot::PackageManagerBase do # rubocop:disable RSpec/FilePath,RSpec/SpecFilePathFormat let(:concrete_class) do Class.new(Dependabot::PackageManagerBase) do - def name - "bundler" - end - - def version - @version ||= Dependabot::Version.new("1.0.0") - end - - def deprecated_versions - [Dependabot::Version.new("1")] - end - - def unsupported_versions - [Dependabot::Version.new("0")] - end - - def supported_versions - @supported_versions ||= [Dependabot::Version.new("1"), Dependabot::Version.new("2")] + def initialize + super( + "bundler", # ecosystem + "bundler", # name + Dependabot::Version.new("1.0.0"), # version + [Dependabot::Version.new("1")], # deprecated_versions + [Dependabot::Version.new("1"), Dependabot::Version.new("2")] # supported_versions + ) end sig { override.returns(T::Boolean) } @@ -49,12 +39,12 @@ def support_later_versions? let(:default_concrete_class) do Class.new(Dependabot::PackageManagerBase) do - def name - "bundler" - end - - def version - Dependabot::Version.new("1.0.0") + def initialize + super( + "bundler", # ecosystem + "bundler", # name + Dependabot::Version.new("1.0.0"), # version + ) end end end @@ -84,16 +74,6 @@ def version end end - describe "#unsupported_versions" do - it "returns an array of unsupported versions" do - expect(package_manager.unsupported_versions).to eq([Dependabot::Version.new("0")]) - end - - it "returns an empty array by default" do - expect(default_package_manager.unsupported_versions).to eq([]) - end - end - describe "#supported_versions" do it "returns an array of supported versions" do expect(package_manager.supported_versions).to eq([