From 20a56036abd9cdd31df1958aaf67b79dc77085b2 Mon Sep 17 00:00:00 2001 From: Bryan Barajas Date: Fri, 18 Oct 2024 14:50:45 +0000 Subject: [PATCH] Fix linter issues --- .../terraform/requirements_updater.rb | 2 -- .../terraform/requirements_updater_spec.rb | 18 ++++++++++++------ 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/terraform/lib/dependabot/terraform/requirements_updater.rb b/terraform/lib/dependabot/terraform/requirements_updater.rb index 3a6e8527b951..6944ef3ead21 100644 --- a/terraform/lib/dependabot/terraform/requirements_updater.rb +++ b/terraform/lib/dependabot/terraform/requirements_updater.rb @@ -11,8 +11,6 @@ require "dependabot/terraform/version" require "dependabot/terraform/requirement" -require 'logger' - module Dependabot module Terraform # Takes an array of `requirements` hashes for a dependency at the old diff --git a/terraform/spec/dependabot/terraform/requirements_updater_spec.rb b/terraform/spec/dependabot/terraform/requirements_updater_spec.rb index 006dd433636a..c3032a91d1c9 100644 --- a/terraform/spec/dependabot/terraform/requirements_updater_spec.rb +++ b/terraform/spec/dependabot/terraform/requirements_updater_spec.rb @@ -77,37 +77,43 @@ end end - context "and a <= requirement was previously specified" do + context "when <= requirement was previously specified" do context "that is satisfied" do let(:requirement) { "<= 0.3.7" } + it { is_expected.to eq(requirements.first) } end - context "that is not satisfied" do + context "when it is not satisfied" do let(:requirement) { "<= 0.1.9" } + its([:requirement]) { is_expected.to eq("<= 0.3.7") } - context "specifying two digits" do + context "when specifying two version segments" do let(:requirement) { "<= 0.3" } let(:latest_version) { version_class.new("2.8.5") } + its([:requirement]) { is_expected.to eq("<= 2.8.5") } end - context "specifying three digits" do + context "when specifying three version segments" do let(:requirement) { "<= 0.3.7" } let(:latest_version) { version_class.new("2.8.5") } + its([:requirement]) { is_expected.to eq("<= 2.8.5") } end - context "minor and patch updated" do + context "when minor and patch updated" do let(:requirement) { "<= 0.3.7" } let(:latest_version) { version_class.new("0.4.0") } + its([:requirement]) { is_expected.to eq("<= 0.4.0") } end - context "major, minor and patch updated" do + context "when major, minor and patch updated" do let(:requirement) { "<= 0.3.7" } let(:latest_version) { version_class.new("1.4.0") } + its([:requirement]) { is_expected.to eq("<= 1.4.0") } end end