Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note to prefer $() over ``, and update single example to conform #100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

matthewcurry
Copy link

Hello,

Most code style guides dictate that $() be used instead of `` for command substitution. I made a very small change to your document to encourage its use.

Thanks,
Matthew

@sumbach
Copy link
Collaborator

sumbach commented Oct 22, 2019

Nice catch, @matthewcurry 😃

I support this 💯 . We might want to swap the order of `` and $() in the prose and sample code block, too, just to reinforce that $() is more common (or should be... 😉 )

@matthewcurry
Copy link
Author

Hey, I added a commit to make the change you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants