Modify call to javac to put options in temp file instead of on command line to prevent problems with command line being too long #4990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d line to prevent 'Command too long' errors when classpath is too long
|
If this is a way forward, and I'll need to think about this idea, we should use the functions in ALE for managing temporary files. Have a look at the documentation for them. I'd link to them, but I'm currently on a train. 😃 |
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the way javac options are passed to avoid "Command too long" errors by writing options to a temporary file and referencing it via the @file syntax.
- The temporary file now contains the necessary javac options.
- Adjusted path strings for Windows compatibility are applied to classpath and source path options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch was created to address the problem of getting 'Command too long' errors from javac becase the classpath is too long.
The change instead writes the javac options to a file in the temporary directory that ALE creates and builds the javac command to use the @<options_file> method of specifying the options.
These changes allowed me to use ALE with my Java projects where previously it failed due to the javac command line being longer than the ~8K allowed by Windows.