Skip to content

Conversation

timreichen
Copy link
Contributor

add deprecation notice to rcompare

@timreichen timreichen requested a review from kt3k as a code owner December 13, 2023 21:58
@iuioiua iuioiua changed the title chore(semver): deprecate rcompare deprecation(semver): deprecate rcompare() Dec 13, 2023
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 45c8201 into denoland:main Dec 14, 2023
@timreichen timreichen mentioned this pull request Jan 1, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants