Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle runner doesn't handle args well #513

Closed
kitsonk opened this issue Jun 20, 2019 · 1 comment · Fixed by #514
Closed

Bundle runner doesn't handle args well #513

kitsonk opened this issue Jun 20, 2019 · 1 comment · Fixed by #514

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Jun 20, 2019

The bundle loader does not handle Deno.args well, in that it expects exactly two args (the path to the runner and the path to the bundle) and doesn't leave the args in a state where the bundle doesn't realise it was bundled. It should remove the runner from the args.
@kitsonk
Copy link
Contributor Author

kitsonk commented Jun 21, 2019

Because the args are frozen, there is no modifying them, but at least we can at least accept >= 2 arguments.

@kitsonk kitsonk mentioned this issue Jun 21, 2019
Merged
@ry ry closed this as completed in #514 Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bundle/run handles Deno.args better.
1 participant
@kitsonk