fix(async): allow numbers greater than Number.MAX_SAFE_INTEGER in deadline (#6810)

Author: lowlighter

async/deadline.ts

@@ -24,7 +24,8 @@ export interface DeadlineOptions {
  * custom `reason` before resolving or timing out.
  * @typeParam T The type of the provided and returned promise.
  * @param p The promise to make rejectable.
- * @param ms Duration in milliseconds for when the promise should time out.
+ * @param ms Duration in milliseconds for when the promise should time out. If
+ * greater than `Number.MAX_SAFE_INTEGER`, the deadline will never expire.
  * @param options Additional options.
  * @returns A promise that will reject if the provided duration runs out before resolving.
  *
@@ -43,7 +44,8 @@ export async function deadline<T>(
   ms: number,
   options: DeadlineOptions = {},
 ): Promise<T> {
-  const signals = [AbortSignal.timeout(ms)];
+  const signals: AbortSignal[] = [];
+  if (ms < Number.MAX_SAFE_INTEGER) signals.push(AbortSignal.timeout(ms));
   if (options.signal) signals.push(options.signal);
   return await abortable(p, AbortSignal.any(signals));
 }

async/deadline_test.ts

@@ -91,3 +91,8 @@ Deno.test("deadline() handles already aborted signal", async () => {
   assertEquals(error.name, "AbortError");
   controller.abort();
 });
+
+Deno.test("deadline() supports numbers greater than Number.MAX_SAFE_INTEGER", async () => {
+  const promise = await deadline(Promise.resolve("Hello"), Infinity);
+  assertEquals(promise, "Hello");
+});