Skip to content

Add Date::new() and Date::value_of() #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2020
Merged

Add Date::new() and Date::value_of() #452

merged 2 commits into from
Sep 2, 2020

Conversation

@bnoordhuis
Copy link
Contributor

@bnoordhuis bnoordhuis commented Sep 1, 2020

Closes: #451

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ry
ry approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben - LGTM

@ry ry merged commit b88f9f5 into denoland:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ry ry ry approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v8::Date::New

3 participants

@bnoordhuis @CLAassistant @ry