Skip to content

Commit ae8748a

Browse files
rypiscisaureus
authored andcommitted
Upgrade V8 to 8.7.25 (#443)
1 parent 8f646b1 commit ae8748a

File tree

10 files changed

+17
-14
lines changed

10 files changed

+17
-14
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Rusty V8 Binding
22

3-
V8 Version: 8.6.334
3+
V8 Version: 8.7.25
44

55
[![ci](https://github.com/denoland/rusty_v8/workflows/ci/badge.svg?branch=master)](https://github.com/denoland/rusty_v8/actions)
66
[![crates](https://img.shields.io/crates/v/rusty_v8.svg)](https://crates.io/crates/rusty_v8)

build

Submodule build updated 115 files

buildtools

Submodule buildtools updated 1 file

tests/test_api.rs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3350,6 +3350,8 @@ extern "C" fn heap_limit_callback(
33503350
current_heap_limit * 2 // Avoid V8 OOM.
33513351
}
33523352

3353+
// This test might fail due to a bug in V8. The upstream bug report is at
3354+
// https://bugs.chromium.org/p/v8/issues/detail?id=10843.
33533355
#[test]
33543356
fn heap_limits() {
33553357
let _setup_guard = setup();
@@ -3366,14 +3368,14 @@ fn heap_limits() {
33663368
let scope = &mut v8::ContextScope::new(scope, context);
33673369

33683370
// Allocate JavaScript arrays until V8 calls the near-heap-limit callback.
3369-
// It takes about 100-200k iterations of this loop to get to that point.
3371+
// It takes about 50-200k iterations of this loop to get to that point.
33703372
for _ in 0..1_000_000 {
33713373
eval(
33723374
scope,
33733375
r#"
33743376
"hello 🦕 world"
3375-
.repeat(5)
3376-
.split("🦕", 2)
3377+
.repeat(10)
3378+
.split("🦕")
33773379
.map((s) => s.split(""))
33783380
.shift()
33793381
"#,
@@ -3400,7 +3402,8 @@ fn heap_statistics() {
34003402
assert!(s.total_global_handles_size() >= s.used_global_handles_size());
34013403
assert!(s.used_heap_size() > 0);
34023404
assert!(s.heap_size_limit() >= s.used_heap_size());
3403-
assert!(s.peak_malloced_memory() >= s.malloced_memory());
3405+
assert!(s.peak_malloced_memory() > 0);
3406+
assert!(s.malloced_memory() > 0);
34043407
assert_eq!(s.number_of_native_contexts(), 0);
34053408

34063409
let scope = &mut v8::HandleScope::new(isolate);

third_party/jinja2

Submodule jinja2 updated from 3f90fa0 to 61cfe2a

third_party/markupsafe

Submodule markupsafe updated from 8f45f5c to f2fb0f2

third_party/zlib

Submodule zlib updated from 7492de9 to d53accf

tools/clang

Submodule clang updated from 8a232eb to 708cbfd

tools/upgrade_v8.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# WARNING: This is not an automated tool! This is just some commands to copy and
22
# paste manually to upgrade V8.
33

4-
export BRANCH=20200806_rusty_v8
5-
export COMMITDATE=2020-08-05T17:03:41.000Z
4+
export BRANCH=20200827_rusty_v8
5+
export COMMITDATE=2020-08-26T18:48:51.000Z
66

77
git submodule update -f
88
git submodule foreach 'git remote rm upstream; true' &&

v8

Submodule v8 updated from ce4c306 to 1f2195b

0 commit comments

Comments
 (0)