Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: publish only "deno" crate on tags #8535

Merged
merged 1 commit into from
Nov 28, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Nov 28, 2020

This commit updates CI script to publish only "deno"
crate on tags.

Following crates are not automatically published anymore:

  • deno_core
  • deno_web
  • deno_fetch
  • deno_crypto

Before this commit creating a new release required to bump
version on all above crates even though in practice they
rarely change.

This commit updates CI script to publish only "deno"
crate on tags.

Following crates are not automatically published anymore:
- deno_core
- deno_web
- deno_fetch
- deno_crypto
@bartlomieju bartlomieju requested a review from ry November 28, 2020 19:21
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 097babb into denoland:master Nov 28, 2020
@bartlomieju bartlomieju deleted the ci_dont_release_core branch November 28, 2020 20:39
@lucacasonato
Copy link
Member

I don't think this will work. deno crate requires the other crates (like deno_core crate). If we don't publish a new deno_core version, cargo will instead pull the old version (from the previous release), breaking the build. This is not an issue if between releases the crates have no changes, but any change (even minor) will require us to manually bump and release the non deno crates. This is theoretically manageable, but seems pretty annoying.

@bartlomieju
Copy link
Member Author

I don't think this will work. deno crate requires the other crates (like deno_core crate). If we don't publish a new deno_core version, cargo will instead pull the old version (from the previous release), breaking the build. This is not an issue if between releases the crates have no changes, but any change (even minor) will require us to manually bump and release the non deno crates. This is theoretically manageable, but seems pretty annoying.

@lucacasonato correct, but now the opposite is true, we're bumping version every week and some crates haven't seen a change for a few weeks.

@lucacasonato
Copy link
Member

Still seems like its going to be very prone to us forgetting to bump one of the op crates, or core 🙃. I guess well see how it goes.

@hayd
Copy link
Contributor

hayd commented Nov 30, 2020

You could fetch the latest cargo version then git diff the directory against that tag (and publish if different).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants