fix(cli/napi): handle all property variants in napi_define_properties #17680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
changed the title
bartlomieju
reviewed
Feb 8, 2023
| method: None, | ||
| getter: None, | ||
| setter: None, | ||
| data: ptr::null_mut(), | ||
| attributes: enumerable, | ||
| value: number, | ||
| }, | ||
| // TODO(@littledivy): Fix this. |
There was a problem hiding this comment.
name field isn't handled correctly. #17712
littledivy
commented
Feb 10, 2023
| @@ -27,7 +27,7 @@ pub mod typedarray; | |||
| #[macro_export] | |||
| macro_rules! cstr { | |||
| ($s: literal) => {{ | |||
| std::ffi::CString::new($s).unwrap().as_ptr() | |||
| std::ffi::CString::new($s).unwrap().into_raw() | |||
There was a problem hiding this comment.
the allocated cstring wasn't leaked so the pointer from .as_ptr was dangling. into_raw leaks it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17509
This fixes the bug that blocked loading
fseventsin Deno.