Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other targets with Deno.bundle #6297

Closed
kitsonk opened this issue Jun 15, 2020 · 1 comment · Fixed by #6328
Closed

Support other targets with Deno.bundle #6297

kitsonk opened this issue Jun 15, 2020 · 1 comment · Fixed by #6328
Labels
cli related to cli/ dir feat new feature (which has been agreed to/accepted)

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Jun 15, 2020

Currently the bundle loader requires ES2017+. That means it isn't suitable for other targets and it isn't transpiled on the fly.

Originally I though we should just transpile for every target, but I think it is just easier to just have a single transpiled version that targets ES5 and if the target is less than < ES2017 it uses ES5. ES3 isn't a realistic target to support for deno bundle or Deno.bundle.

@kitsonk kitsonk mentioned this issue Jun 15, 2020
18 tasks
@bartlomieju bartlomieju added cli related to cli/ dir feat new feature (which has been agreed to/accepted) labels Jun 16, 2020
@kitsonk kitsonk changed the title Support other targets with deno bundle/Deno.bundle Support other targets with Deno.bundle Jun 17, 2020
@iugo
Copy link
Contributor

iugo commented Aug 26, 2020

How to use deno bundle target to ES5?

There are no related options in deno bundle --help.

When I use tsconfig.json "compilerOptions": { "target": "es5" }, tips "Unsupported compiler options".

deno 1.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli related to cli/ dir feat new feature (which has been agreed to/accepted)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants