Getting Started issues

[ericfrederich]

Version: Deno 2.0.6
OS: Ubuntu 24.04 via WSL2

Couple of issues I noticed simply running curl -fsSL https://deno.land/install.sh | sh as instructed in the Getting Started page

• It appends . "/home/username/.deno/env" to my ~/.bashrc and ~/.profile but does not add a trailing newline. Obviously a bug because it means subsequent scripts that want to do the same thing would end up appending to that line.
• After selecting bash when asked "Set up completions?" I get the message: warning: Failed to install completions for bash: PermissionDenied: Permission denied (os error 13): mkdir '/usr/local/etc/bash_completion.d'. The docs do not mention the need to run this as root. Perhaps those files should be installed in the user's directory and not globally.

[uncomfyhalomacro]

Hi @ericfrederich. I think this could be fixed easily by just adjusting their install script. I also filed a duplicate issue at #26824

[uncomfyhalomacro]

I will close mine in favour of this since it also seems it has another issue written here.

[ericfrederich]

Thanks @uncomfyhalomacro. Perhaps it should be discussed the proper place on Linux to put these. This isn't my area of expertise to say that it should be in ~/.local/share/bash-completion/completions.

When I look at my system I actually don't have an existing ~/.local/share/bash-completion directory. I do however have some completion files in app specific directories.

• /home/username/.pyenv/completions/pyenv.bash
• /home/username/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/etc/bash_completion.d/cargo
• /home/username/.nvm/bash_completion

Perhaps the completions should be put in the user's directory under ~/.deno. This seems to be the pattern other tools are using (whether right or wrong).

[uncomfyhalomacro]

I don't remember bash reading those directories (i also think it requires an environmental variable). i do believe that the proposal i have is where bash usually looks for completions

• /usr/share/bash-completion/completions
• /usr/local/share/bash-completion/completion
• /etc/bash_completion.d
• /usr/local/etc/bash_completion.d
• ~/.local/share/bash-completion/completions

i might be wrong so it still requires discussion.

i think just putting them in "standard" bash completion directories should be okay