From cf06a7c7e672880e1b38598fe445e2c50b4a9d06 Mon Sep 17 00:00:00 2001 From: Bert Belder Date: Fri, 10 Feb 2023 20:41:20 +0100 Subject: [PATCH] refactor(ext/http): use `String.prototype.trim()` instead of regex (#17722) --- ext/http/01_http.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/ext/http/01_http.js b/ext/http/01_http.js index 6807ad973d6b59..1da371e8dd9f53 100644 --- a/ext/http/01_http.js +++ b/ext/http/01_http.js @@ -51,6 +51,7 @@ const { StringPrototypeIncludes, StringPrototypeToLowerCase, StringPrototypeSplit, + StringPrototypeTrim, Symbol, SymbolAsyncIterator, TypeError, @@ -393,8 +394,9 @@ function upgradeWebSocket(request, options = {}) { const upgrade = request.headers.get("upgrade"); const upgradeHasWebSocketOption = upgrade !== null && ArrayPrototypeSome( - StringPrototypeSplit(upgrade, /\s*,\s*/), - (option) => StringPrototypeToLowerCase(option) === "websocket", + StringPrototypeSplit(upgrade, ","), + (option) => + StringPrototypeToLowerCase(StringPrototypeTrim(option)) === "websocket", ); if (!upgradeHasWebSocketOption) { throw new TypeError( @@ -405,8 +407,9 @@ function upgradeWebSocket(request, options = {}) { const connection = request.headers.get("connection"); const connectionHasUpgradeOption = connection !== null && ArrayPrototypeSome( - StringPrototypeSplit(connection, /\s*,\s*/), - (option) => StringPrototypeToLowerCase(option) === "upgrade", + StringPrototypeSplit(connection, ","), + (option) => + StringPrototypeToLowerCase(StringPrototypeTrim(option)) === "upgrade", ); if (!connectionHasUpgradeOption) { throw new TypeError(