Skip to content

endpoints: rename built-in type 'https' -> 'http' (cl-epfk)#499

Open
arnauorriols wants to merge 1 commit into
mainfrom
polecat/chrome-mpe42qg1
Open

endpoints: rename built-in type 'https' -> 'http' (cl-epfk)#499
arnauorriols wants to merge 1 commit into
mainfrom
polecat/chrome-mpe42qg1

Conversation

@arnauorriols
Copy link
Copy Markdown
Member

The built-in TLS-wrapped HTTP endpoint plugin was registered as type "https". Renames the type identifier to "http" everywhere it appears: plugin registration, HCL block labels, typed references (https.X -> http.X), example configs, testdata + golden JSON, and docs. Other endpoint types containing "https" in their identifier (clickhouse_https, openai_codex_https, example_https) are unchanged.

Also renames the exported Go types HTTPSEndpoint / HTTPSEndpointRuntime to HTTPEndpoint / HTTPEndpointRuntime and the file https.go -> http.go to match. Regenerates docgen output and site/src/lib/examples.ts from the updated source HCL.

The "https" facet (action facet, package path, https-mitm transport) and URL-scheme strings are out of scope and untouched.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 20, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
clawpatrol 95bfcec Commit Preview URL

Branch Preview URL
May 21 2026, 03:13 PM

Copy link
Copy Markdown
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@arnauorriols
Copy link
Copy Markdown
Member Author

sync with main and fix git conflicts

The built-in TLS-wrapped HTTP endpoint plugin was registered as
type "https". Renames the type identifier to "http" everywhere it
appears: plugin registration, HCL block labels, typed references
(https.X -> http.X), example configs, testdata + golden JSON, and
docs. Other endpoint types containing "https" in their identifier
(clickhouse_https, openai_codex_https, example_https) are unchanged.

Also renames the exported Go types HTTPSEndpoint /
HTTPSEndpointRuntime to HTTPEndpoint / HTTPEndpointRuntime and the
file https.go -> http.go to match. Regenerates docgen output and
site/src/lib/examples.ts from the updated source HCL.

The "https" facet (action facet, package path, https-mitm transport)
and URL-scheme strings are out of scope and untouched.
@arnauorriols arnauorriols force-pushed the polecat/chrome-mpe42qg1 branch from 11d67d5 to 95bfcec Compare May 21, 2026 15:12
@arnauorriols
Copy link
Copy Markdown
Member Author

[bot-reply]
Pushed 95bfcec (force-push of rebased branch onto main) addressing this comment:

  • Rebased onto current main and resolved conflicts across 18 files (test fixtures, plugin source, docs, generated examples).
  • Adopted main's gateway block / new schema in conflicting HCL fixtures; preserved the PR's httpshttp endpoint-type rename throughout.
  • Updated tests added on main that still referenced the old endpoint "https" type (internal/config/compile_test.go, internal/config/runtime/dispatch_test.go) and the bundled examples/gateway.example.hcl.
  • Regenerated site/src/lib/examples.ts from the updated examples/*.hcl sources.
  • Verified: gofmt -l . clean, go build ./..., go vet ./..., full go test ./... green; make fmt-check, dashboard lint + build, and clawpatrol validate on every examples/*.hcl all pass.

@github-actions
Copy link
Copy Markdown

🚀 Preview deployed: https://demo.clawpatrol.dev/pr-preview/pr-499/

Built from 95bfceccfb8fc04430a697b64fdf507faf3ed9a8 at 2026-05-21T15:12:36Z.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants