From 2c46a6071f4d1369a5c101a7fc7e6cdf58b6c3ab Mon Sep 17 00:00:00 2001 From: John Ferguson Smart Date: Fri, 28 Sep 2012 08:01:25 +1000 Subject: [PATCH 1/7] Updated versions --- gameoflife-build/pom.xml | 2 +- gameoflife-core/pom.xml | 2 +- gameoflife-web/pom.xml | 4 ++-- pom.xml | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gameoflife-build/pom.xml b/gameoflife-build/pom.xml index f5b73936a1..3df01726e1 100644 --- a/gameoflife-build/pom.xml +++ b/gameoflife-build/pom.xml @@ -4,7 +4,7 @@ gameoflife com.wakaleo.gameoflife - 0.9.66-SNAPSHOT + 1.0-SNAPSHOT gameoflife-build jar diff --git a/gameoflife-core/pom.xml b/gameoflife-core/pom.xml index a1f80e30df..80abb4f332 100644 --- a/gameoflife-core/pom.xml +++ b/gameoflife-core/pom.xml @@ -4,7 +4,7 @@ gameoflife com.wakaleo.gameoflife - 0.9.66-SNAPSHOT + 1.0-SNAPSHOT com.wakaleo.gameoflife gameoflife-core diff --git a/gameoflife-web/pom.xml b/gameoflife-web/pom.xml index 7c0cbd5d8b..4b86102a44 100644 --- a/gameoflife-web/pom.xml +++ b/gameoflife-web/pom.xml @@ -4,7 +4,7 @@ gameoflife com.wakaleo.gameoflife - 0.9.66-SNAPSHOT + 1.0-SNAPSHOT com.wakaleo.gameoflife gameoflife-web @@ -121,7 +121,7 @@ com.wakaleo.gameoflife gameoflife-core - 0.9.66-SNAPSHOT + 1.0-SNAPSHOT com.wakaleo.gameoflife diff --git a/pom.xml b/pom.xml index b24086d4b8..36e242a705 100644 --- a/pom.xml +++ b/pom.xml @@ -3,7 +3,7 @@ 4.0.0 com.wakaleo.gameoflife gameoflife - 0.9.66-SNAPSHOT + 1.0-SNAPSHOT pom gameoflife https://github.com/wakaleo/game-of-life From 019435f7db77b2ac9749376071b079464d4b1d38 Mon Sep 17 00:00:00 2001 From: John Ferguson Smart Date: Sat, 29 Sep 2012 10:57:44 -0700 Subject: [PATCH 2/7] Adapted tests to work better for the CD demo --- .../com/wakaleo/gameoflife/webtests/pages/EnterGridPage.java | 2 +- .../com/wakaleo/gameoflife/webtests/pages/GameOfLifePage.java | 2 +- .../java/com/wakaleo/gameoflife/webtests/pages/HomePage.java | 2 +- pom.xml | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gameoflife-acceptance-tests/src/test/java/com/wakaleo/gameoflife/webtests/pages/EnterGridPage.java b/gameoflife-acceptance-tests/src/test/java/com/wakaleo/gameoflife/webtests/pages/EnterGridPage.java index 7266322511..9965131f15 100644 --- a/gameoflife-acceptance-tests/src/test/java/com/wakaleo/gameoflife/webtests/pages/EnterGridPage.java +++ b/gameoflife-acceptance-tests/src/test/java/com/wakaleo/gameoflife/webtests/pages/EnterGridPage.java @@ -6,7 +6,7 @@ import org.openqa.selenium.WebElement; import org.openqa.selenium.support.FindBy; -@DefaultUrl("http://localhost:9090/new") +@DefaultUrl("http://localhost:9090/gameoflife/new") public class EnterGridPage extends GameOfLifePage { @FindBy(id = "submit") diff --git a/gameoflife-acceptance-tests/src/test/java/com/wakaleo/gameoflife/webtests/pages/GameOfLifePage.java b/gameoflife-acceptance-tests/src/test/java/com/wakaleo/gameoflife/webtests/pages/GameOfLifePage.java index bba2c37763..73c9d6d459 100644 --- a/gameoflife-acceptance-tests/src/test/java/com/wakaleo/gameoflife/webtests/pages/GameOfLifePage.java +++ b/gameoflife-acceptance-tests/src/test/java/com/wakaleo/gameoflife/webtests/pages/GameOfLifePage.java @@ -6,7 +6,7 @@ import org.openqa.selenium.WebElement; import org.openqa.selenium.support.FindBy; -@DefaultUrl("http://localhost:9090") +@DefaultUrl("http://localhost:9090/gameoflife") public class GameOfLifePage extends PageObject { @FindBy(linkText = "home") diff --git a/gameoflife-acceptance-tests/src/test/java/com/wakaleo/gameoflife/webtests/pages/HomePage.java b/gameoflife-acceptance-tests/src/test/java/com/wakaleo/gameoflife/webtests/pages/HomePage.java index a116593aa0..d1503b771a 100644 --- a/gameoflife-acceptance-tests/src/test/java/com/wakaleo/gameoflife/webtests/pages/HomePage.java +++ b/gameoflife-acceptance-tests/src/test/java/com/wakaleo/gameoflife/webtests/pages/HomePage.java @@ -5,7 +5,7 @@ import org.openqa.selenium.WebElement; import org.openqa.selenium.support.FindBy; -@DefaultUrl("http://localhost:9090/home") +@DefaultUrl("http://localhost:9090/gameoflife/home") public class HomePage extends GameOfLifePage { @FindBy(linkText = "New Game") diff --git a/pom.xml b/pom.xml index 0678f8a2df..8f0efc9411 100644 --- a/pom.xml +++ b/pom.xml @@ -16,6 +16,7 @@ 1.6 wakaleo 0.9.22 + gameoflife @@ -134,10 +135,9 @@ ${jelastic.username} ${jelastic.password} - gameoflife + ${jelastic.context} wakaleo app.jelastic.servint.net - gameoflife From b2dbba194e942ada0977f8105bf61d62613ef41c Mon Sep 17 00:00:00 2001 From: John Ferguson Smart Date: Sat, 29 Sep 2012 11:10:16 -0700 Subject: [PATCH 3/7] Fixed merge issue --- gameoflife-web/pom.xml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/gameoflife-web/pom.xml b/gameoflife-web/pom.xml index d94626be51..ebba304fc7 100644 --- a/gameoflife-web/pom.xml +++ b/gameoflife-web/pom.xml @@ -121,17 +121,8 @@ com.wakaleo.gameoflife gameoflife-core -<<<<<<< HEAD 1.0-SNAPSHOT - - com.wakaleo.gameoflife - gameoflife-webservice - 0.9.66-SNAPSHOT -======= - 0.9.67-SNAPSHOT ->>>>>>> master - org.springframework spring-webmvc From f0020d5a17362c90044e57534b9b42085bc10fcf Mon Sep 17 00:00:00 2001 From: John Ferguson Smart Date: Sat, 29 Sep 2012 11:28:44 -0700 Subject: [PATCH 4/7] We can now deploy to different platforms: --- pom.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 8f0efc9411..cdc47e6191 100644 --- a/pom.xml +++ b/pom.xml @@ -17,6 +17,7 @@ wakaleo 0.9.22 gameoflife + wakaleo @@ -136,7 +137,7 @@ ${jelastic.username} ${jelastic.password} ${jelastic.context} - wakaleo + ${jelastic.environment} app.jelastic.servint.net From 0da8942f2b20a787263dfca7ee1765b61839b616 Mon Sep 17 00:00:00 2001 From: John Ferguson Smart Date: Sat, 29 Sep 2012 12:10:57 -0700 Subject: [PATCH 5/7] Updated thucydides for the acceptance tests --- gameoflife-acceptance-tests/pom.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gameoflife-acceptance-tests/pom.xml b/gameoflife-acceptance-tests/pom.xml index 8035e04a73..31c2391138 100644 --- a/gameoflife-acceptance-tests/pom.xml +++ b/gameoflife-acceptance-tests/pom.xml @@ -5,7 +5,7 @@ gameoflife com.wakaleo.gameoflife - 0.9.47-SNAPSHOT + 1.0-SNAPSHOT gameoflife-acceptance-tests gameoflife-acceptance-tests @@ -16,6 +16,7 @@ 9999 http://localhost:${jetty.port} firefox + 0.9.22 From 03fbe777a53452ddde8f975be9d6699d9e468e87 Mon Sep 17 00:00:00 2001 From: John Ferguson Smart Date: Sat, 29 Sep 2012 19:29:41 -0700 Subject: [PATCH 6/7] Adjusting PMD config --- pom.xml | 64 +++++++++++++++------------------------------------------ 1 file changed, 17 insertions(+), 47 deletions(-) diff --git a/pom.xml b/pom.xml index cdc47e6191..445be8f3d7 100644 --- a/pom.xml +++ b/pom.xml @@ -234,66 +234,36 @@ metrics - - - - org.codehaus.mojo - cobertura-maven-plugin - ${cobertura.version} - - - html - xml - - - - - - clean - check - - - - - - - maven-checkstyle-plugin - 2.9.1 - - - com.wakaleo.gameoflife - gameoflife-build - ${project.version} - - - - custom-checkstyle.xml - - + + + + + + + + + + + + + + org.apache.maven.plugins maven-pmd-plugin 2.5 - - - com.wakaleo.gameoflife - gameoflife-build - ${project.version} - - 1.6 true xml - - pmd-rules.xml - 20 - true + + true + 2 From e90a926524ea36dabaafc5653b4015aa6eb71fdb Mon Sep 17 00:00:00 2001 From: John Ferguson Smart Date: Sat, 29 Sep 2012 20:27:42 -0700 Subject: [PATCH 7/7] Isolate the acceptance tests from the other modules --- gameoflife-acceptance-tests/pom.xml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/gameoflife-acceptance-tests/pom.xml b/gameoflife-acceptance-tests/pom.xml index 31c2391138..2a33e57db3 100644 --- a/gameoflife-acceptance-tests/pom.xml +++ b/gameoflife-acceptance-tests/pom.xml @@ -2,12 +2,9 @@ 4.0.0 - - gameoflife - com.wakaleo.gameoflife - 1.0-SNAPSHOT - + com.wakaleo.gameoflife gameoflife-acceptance-tests + 1.0-SNAPSHOT gameoflife-acceptance-tests 0.9.22