Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize jsonSpec and jsonConfig as standalone JSON/JSONC files when saving a report using the Power BI enhanced report format (PBIR) #462

Open
jol1 opened this issue Jun 18, 2024 · 3 comments

Comments

@jol1
Copy link

jol1 commented Jun 18, 2024

This is a feature that likely can't be implemented without Microsoft first enhancing the PBIR serializer and the Power BI visual SDK. Please vote for my Idea!
Serialize visual custom code (R/Python script visual, Deneb, etc.) as standalone files when saving a report using the Power BI enhanced report format (PBIR) - Microsoft Fabric Ideas

The purpose of the Power BI enhanced report format (PBIR) is to make report definitions more friendly when under source control, and to enable offline editing. This feature means that the Vega or Vega-Lite specification and configuration within a Deneb visual would be saved as standalone JSON files, rather than being embedded within strings (filled with escaped new line and double-quote characters) inside the "visual.json" file.

@jol1
Copy link
Author

jol1 commented Jun 19, 2024

This is what the "visual.json" file currently looks like for a Deneb visual in a report saved using the Power BI enhanced report format (PBIR)
Deneb

@dm-p
Copy link
Member

dm-p commented Jun 19, 2024

This is a great idea! I will certainly vote it up 👍

One thing we will need to consider for such a feature is that Deneb will have JSONC support with the next update, and comments are not a part of the JSON spec (meaning that all JSONC is actually parsed as serialized/string format anyway).

If this were to work I feel that indeed MS would need to add visuals SDK support for PBIR hooks that can specify properties and file types that can be "exported" when this happens, so being able to specify the file type would be very useful. I'll also add some thoughts to the idea when I get some time to think through in detail.

@dm-p dm-p added this to the Blue Sky Features milestone Jun 19, 2024
@dm-p
Copy link
Member

dm-p commented Jun 19, 2024

Of note, the potential for PBIR is pretty exciting and it's on my list to have a think about how we can work with this constraint anyway (even if we need some intermediate tooling), so if you have any ideas, please feel free to raise them :)

@jol1 jol1 changed the title Serialize jsonSpec and jsonConfig as standalone JSON files when saving a report using the Power BI enhanced report format (PBIR) Serialize jsonSpec and jsonConfig as standalone JSON/JSONC files when saving a report using the Power BI enhanced report format (PBIR) Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants