Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating a link, lookup is not working if the note title is digits only. #3676

Open
1 of 7 tasks
oolonek opened this issue Oct 15, 2022 · 3 comments
Open
1 of 7 tasks
Labels
scope.lookup Anything Lookup related type.bug Something isn't working

Comments

@oolonek
Copy link

oolonek commented Oct 15, 2022

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

  • Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
  • Lookup. Dendron's Lookup Command
  • Views. Dendron Preview, Tree View, Side Panels in the UI
  • Schema. Dendron Schemas
  • Pod. Data import from / export to Dendron
  • Publish. External Site Publish
  • Markdown. Markdown features, such as syntax support and features

Describe the bug

I have a note called 404. The full path is dendron.publish.404.md

If I lookup for 'publish' the note is listed.

image

If I look up for 404 it doesn't appears

image

Note: this behavior is observed when autocompleting a link. That is by starting to type the pattern with the double [[]]
The Note lookup allows to retrieve the 404 note.

To Reproduce

Steps to reproduce the behavior:

  1. Create a new note with digits only title.
  2. Create a link by typing [[]]
  3. Lookup the note by typing the digits
  4. See error

Expected behavior

Same behavior as when looking for a letter based pattern

Screenshots

See above.

Desktop (please complete the following information)

  • OS: MacOS
  • Versions (all that apply to bug):
    • VS Code version: 1.72.2
    • Dendron CLI: 0.115
@github-actions github-actions bot added scope.lookup Anything Lookup related status.triage-needed type.bug Something isn't working labels Oct 15, 2022
@oolonek oolonek changed the title Lookup note, when creating a link, not working on if note title is digits only. When creating a link, lookup is not working if the note title is digits only. Oct 15, 2022
@jonathanyeung
Copy link
Contributor

Hmm - I'm currently unable to repro. When typing out '404' did you hit backspace at any point? That's a known issue in that you won't get suggestions anymore after deleting a character.

image

@oolonek
Copy link
Author

oolonek commented Oct 17, 2022

Just tested now. And no backspace hitting.
Not working.
One thing I am noticing (not sure it has anything to do though) is that I have duplicated suggestion in the lookup.
Ones with the lines icon like you have and ones with the .md icon. Is that expected ?

image

It's not a big issue and I can definitively live without it. Just thought I would file the bug report in case ...

@jonathanyeung
Copy link
Contributor

The presence of multiple entries makes me think that maybe there's another markdown extension that's contributing entries in the autocomplete - only the ones without the '.md' suffix are the ones being contributed by Dendron. Potentially the extension may also be interfering with the results?

I'll keep an eye out - the autocomplete feature can be a bit finicky at times. Thanks for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope.lookup Anything Lookup related type.bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants