Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create scratch note when no file is opened #2002

Open
1 of 7 tasks
jaroslavknotek opened this issue Dec 29, 2021 · 2 comments
Open
1 of 7 tasks

Cannot create scratch note when no file is opened #2002

jaroslavknotek opened this issue Dec 29, 2021 · 2 comments
Assignees
Labels
scope.lookup Anything Lookup related type.bug Something isn't working

Comments

@jaroslavknotek
Copy link

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

  • Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
  • Lookup. Dendron's Lookup Command
  • Views. Dendron Preview, Tree View, Side Panels in the UI
  • Schema. Dendron Schemas
  • Pod. Data import from / export to Dendron
  • Publish. External Site Publish
  • Markdown. Markdown features, such as syntax support and features

Describe the bug

I can't create new scratch note when no file is open. Instead, I get this error:

error while running command: Must be run from within a note

Judging by this related issue I would expect that this is not expected behavior.

To Reproduce

Steps to reproduce the behavior:

  1. Install codium 1.63.2
  2. install dendron v0.75.0
  3. Launch Tutorial - to ensure that all settings are default
  4. Close all opened editors
  5. Press shift+ctrl+s

Expected behavior

new scratch note scratch.<yyyyMMddHHmm>.md is created in the workspace folder.

@github-actions github-actions bot added scope.lookup Anything Lookup related status.triage-needed type.bug Something isn't working labels Dec 29, 2021
@hikchoi
Copy link
Contributor

hikchoi commented Dec 30, 2021

Thanks for the report. I can reproduce this.
This is occuring because we try to derive the scratch note's name from the open editor, and we didn't properly handle the default case of not having a note open.

We'll let you know when this gets fixed 🙏🏼

@hikchoi hikchoi self-assigned this Jan 6, 2022
@aleksey-rowan
Copy link
Contributor

The behaviour has changed slightly :) Now it let's you create a scratch note, but not autofills the name:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope.lookup Anything Lookup related type.bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants