Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using flags to specify whether path or name is returned #4

Open
fhightower opened this issue Feb 13, 2021 · 1 comment
Open
Labels
enhancement New feature or request time est: 1 hour We estimate this issue will take 1 hour to complete

Comments

@fhightower
Copy link
Contributor

For example, rather than having directory_subdirectory_names and directory_subdirectory_paths, simply have directory_subdirectories(dir_path: str, return_paths: bool = False) where the return_paths flag determines whether the returned items are paths or file names.

This would involve consolidating and simplifying the code and interfaces in this library.

This ticket also involves changing the function calls in all of the democritus libraries that use these functions.

@fhightower fhightower added enhancement New feature or request time est: 1 hour We estimate this issue will take 1 hour to complete labels Feb 13, 2021
@fhightower
Copy link
Contributor Author

This also applies to the directory_file_names_matching and directory_file_paths_matching functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request time est: 1 hour We estimate this issue will take 1 hour to complete
Projects
None yet
Development

No branches or pull requests

1 participant