Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add typings for query string parser #387

Merged
merged 3 commits into from
Feb 5, 2025
Merged

chore: add typings for query string parser #387

merged 3 commits into from
Feb 5, 2025

Conversation

vwong
Copy link
Contributor

@vwong vwong commented Jan 30, 2025

No description provided.

Eomm
Eomm reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the tests https://github.com/delvedor/find-my-way/blob/main/test/types/router.test-d.ts ?

@vwong
Copy link
Contributor Author

vwong commented Jan 30, 2025

Updated.. Is this what you mean?

mcollina
mcollina approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm
Copy link
Contributor

Eomm commented Jan 31, 2025

Updated.. Is this what you mean?

Yes, but the CI fails with this error now:

  test/types/router.test-d.ts:20:37
  ✖  20:37  => expected.  
  ✖  96:37  => expected.

@vwong
Copy link
Contributor Author

vwong commented Jan 31, 2025

Ah, sorry I was coding blind for a while, because I couldn't manage to run the test locally with my local version of node 20.. When I switched to node 22, I was able to reproduce the error in CI, and fixed it. Should be good now.

@vwong
Copy link
Contributor Author

vwong commented Jan 31, 2025

Sorry for the back and forth...

mcollina
mcollina approved these changes Feb 1, 2025
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vwong
Copy link
Contributor Author

vwong commented Feb 5, 2025

Any chance we can release this?

@mcollina mcollina merged commit e9410f7 into delvedor:main Feb 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm left review comments

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vwong @Eomm @mcollina