Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoding of %2F #348

Closed
jimmythomson opened this issue Feb 19, 2024 · 2 comments
Closed

Decoding of %2F #348

jimmythomson opened this issue Feb 19, 2024 · 2 comments

Comments

@jimmythomson
Copy link

Could I please clarify that the decoding of %2F before looking up the route is expected behaviour? I imagine it must be given that the change looks to have been implemented a couple of years ago, however I see this comment which explicitly calls out that...

we don't want to decode the /(%2F) because it defines the URL segment and it is a path parameter

So my expectation was that a path of /test/my%2Fkey would match /test/:key where the value of the key param would be my/key. However, it appears that the path is decoded to /test/my/key before being matched, and therefore does not match /test/:key. Is this intended behaviour?

I appreciate I can use a wildcard to match, but that then makes parsing of any additional param more awkward.

Thanks!

@mcollina
Copy link
Collaborator

cc @Eomm

@jimmythomson
Copy link
Author

Hi guys - please don't spend any time on this. I'm not actually sure there's an issue here. I'm having a look through the code and all appears to work as I'd expect, so I'm now tracking down where the underlying issue is. I'll close this issue for now and then re-open if it turns out there is an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants