Merged master #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delta1
commented
Dec 12, 2024
|
|
||
| BITCOIN_DAEMON_NAME=elementsd | ||
| BITCOIN_GUI_NAME=elements-qt | ||
| BITCOIN_TEST_NAME=test_bitcoin |
delta1
force-pushed
the
merged-master
branch
5 times, most recently
from
b706b27 to
c794f76
Compare
delta1
force-pushed
the
merged-master
branch
6 times, most recently
from
c0fb941 to
b6ea43a
Compare
delta1
force-pushed
the
merged-master
branch
2 times, most recently
from
0b2d6a4 to
0c1e24a
Compare
chore: replaced the non-working travis badge with a release
…olve_data Removed duplicate solving_data for transaction funding RPCs
syscall sandbox was removed upstream in bitcoin/bitcoin#27896
tomt1664
pushed a commit
to tomt1664/elements
that referenced
this pull request
Jan 26, 2026
This changed the node pruning logic and moved test/functional/feature_blockfilterindex_prune.py to test/functional/feature_index_prune.py. Please verify that: 1. I migrated the test correctly 2. The magic numbers in the test look fine With respect to delta1#2: I believe the magic numbers are wrong. I previously had to tweak them heavily in commit 1278b31. I don't think I did it correctly then, and so I don't believe them to be correct now. To summarize what this tweaking was: I changed the magic numbers in the test to work properly, but I suspect that in changing them, I may have nullified what the test was testing. It's very possible that the reason the test was failing was because of an underlying bug with the pruning in elements which we have to fix, rather than just being an issue with the test itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.