Switch to Python 3 [Backport of #9 to 6.0.3.0] #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don-brady
requested review from
johngallagher-dlpx,
sebroy and
brad-lewis
and removed request for
johngallagher-dlpx
brad-lewis
approved these changes
May 13, 2020
|
Can you spot-check that estat and stbtrace both work correctly? I don't know if either are covered by the testing included in ab-pre-push. |
good call! looks like there are issues with |
|
@sebroy rebased on top of fentry commit and performed a spot check as suggested. |
johngallagher-dlpx
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mostly clean cherry-pick. Had to drop one unnecessary style cleanup since #21 has not yet landed in stage.
ab-pre-push is at: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/3481/
On image from above^, spot checked estat and also verified the analytic probes are working