Skip to content

Fetch dependency of linux dbgsym package when downloading kernel packages #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

pzakha
Copy link
Contributor

@pzakha pzakha commented Oct 19, 2020

The idea for the linux-pkg's linux-kernel-* packages, is that we will store in S3 all of the linux-kernel packages required to build the Delphix Appliance, without relying on the linux-package-mirror snapshot that is passed to appliance-build to contain them.

Some linux-kernel packages have dependencies on other linux-kernel packages. It seems that in some cases the dbgsym package has dependencies on another dbgsym package with a slightly different naming convention, and we were not downloading it.

Here's an example:
linux-image-5.4.0-48-generic-dbgsym depends on linux-image-unsigned-5.4.0-48-generic-dbgsym.

Note that we've already had some logic to deal with a similar issue that we had with the "tools" and "headers" packages, so this just extends the same logic to the dbgsym package.

Testing

build-kernel: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/linux-pkg/job/master/job/build-kernel/job/pre-push/3/console
List of debs produced (i.e. downloaded) by the linux-kernel-generic package:

linux-headers-5.4.0-48-generic_5.4.0-48.52~18.04.1_amd64.deb
linux-hwe-5.4-headers-5.4.0-48_5.4.0-48.52~18.04.1_all.deb
linux-hwe-5.4-tools-5.4.0-48_5.4.0-48.52~18.04.1_amd64.deb
linux-image-5.4.0-48-generic-dbgsym_5.4.0-48.52~18.04.1_amd64.ddeb
linux-image-5.4.0-48-generic_5.4.0-48.52~18.04.1_amd64.deb
linux-image-unsigned-5.4.0-48-generic-dbgsym_5.4.0-48.52~18.04.1_amd64.ddeb
linux-modules-5.4.0-48-generic_5.4.0-48.52~18.04.1_amd64.deb
linux-tools-5.4.0-48-generic_5.4.0-48.52~18.04.1_amd64.deb

@pzakha pzakha requested a review from sdimitro October 19, 2020 17:18
@pzakha pzakha merged commit 077b4e0 into delphix:master Nov 3, 2020
pzakha added a commit to pzakha/linux-pkg that referenced this pull request Nov 16, 2020
pzakha added a commit to pzakha/linux-pkg that referenced this pull request Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants