Skip to content

Commit fd9a2e1

Browse files
committed
NFSD: Protect against filesystem freezing
Flole observes this WARNING on occasion: [1210423.486503] WARNING: CPU: 8 PID: 1524732 at fs/ext4/ext4_jbd2.c:75 ext4_journal_check_start+0x68/0xb0 Reported-by: <flole@flole.de> Suggested-by: Jan Kara <jack@suse.cz> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217123 Fixes: 73da852 ("nfsd: use vfs_iter_read/write") Reviewed-by: Jeff Layton <jlayton@kernel.org> Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent fb5b855 commit fd9a2e1

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

fs/nfsd/vfs.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1104,7 +1104,9 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct nfsd_file *nf,
11041104
since = READ_ONCE(file->f_wb_err);
11051105
if (verf)
11061106
nfsd_copy_write_verifier(verf, nn);
1107+
file_start_write(file);
11071108
host_err = vfs_iter_write(file, &iter, &pos, flags);
1109+
file_end_write(file);
11081110
if (host_err < 0) {
11091111
nfsd_reset_write_verifier(nn);
11101112
trace_nfsd_writeverf_reset(nn, rqstp, host_err);

0 commit comments

Comments
 (0)