Skip to content

Commit fbcab13

Browse files
Josef BacikShuah Khan
authored andcommitted
selftests: silence test output by default
Some of the networking tests are very noisy and make it impossible to see if we actually passed the tests as they run. Default to suppressing the output from any tests run in order to make it easier to track what failed. Signed-off-by: Josef Bacik <jbacik@fb.com> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
1 parent 84c0656 commit fbcab13

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/testing/selftests/lib.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ define RUN_TESTS
2424
echo "selftests: Warning: file $$BASENAME_TEST is not executable, correct this.";\
2525
echo "not ok 1..$$test_num selftests: $$BASENAME_TEST [FAIL]"; \
2626
else \
27-
cd `dirname $$TEST` > /dev/null; (./$$BASENAME_TEST && echo "ok 1..$$test_num selftests: $$BASENAME_TEST [PASS]") || echo "not ok 1..$$test_num selftests: $$BASENAME_TEST [FAIL]"; cd - > /dev/null;\
27+
cd `dirname $$TEST` > /dev/null; (./$$BASENAME_TEST > /tmp/$$BASENAME_TEST 2>&1 && echo "ok 1..$$test_num selftests: $$BASENAME_TEST [PASS]") || echo "not ok 1..$$test_num selftests: $$BASENAME_TEST [FAIL]"; cd - > /dev/null;\
2828
fi; \
2929
done;
3030
endef
@@ -55,7 +55,7 @@ endif
5555
define EMIT_TESTS
5656
@for TEST in $(TEST_GEN_PROGS) $(TEST_PROGS); do \
5757
BASENAME_TEST=`basename $$TEST`; \
58-
echo "(./$$BASENAME_TEST && echo \"selftests: $$BASENAME_TEST [PASS]\") || echo \"selftests: $$BASENAME_TEST [FAIL]\""; \
58+
echo "(./$$BASENAME_TEST > /tmp/$$BASENAME_TEST 2>&1 && echo \"selftests: $$BASENAME_TEST [PASS]\") || echo \"selftests: $$BASENAME_TEST [FAIL]\""; \
5959
done;
6060
endef
6161

0 commit comments

Comments
 (0)