scsi: fnic: Return error if vmalloc() failed

dTenebrae · martinkpetersen · commit f5f27a332a14 · 2023-12-05T21:01:52.000-05:00
In fnic_init_module() exists redundant check for return value from fnic_debugfs_init(), because at moment it only can return zero. It make sense to process theoretical vmalloc() failure. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 9730ddf ("scsi: fnic: remove redundant assignment of variable rc") Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru> Link: https://lore.kernel.org/r/20231128111008.2280507-1-artem.chernyshev@red-soft.ru Reviewed-by: Karan Tilak Kumar <kartilak@cisco.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/fnic/fnic_debugfs.c b/drivers/scsi/fnic/fnic_debugfs.c
@@ -52,9 +52,10 @@ int fnic_debugfs_init(void)
 		fc_trc_flag->fnic_trace = 2;
 		fc_trc_flag->fc_trace = 3;
 		fc_trc_flag->fc_clear = 4;
+		return 0;
 	}
 
-	return 0;
+	return -ENOMEM;
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -52,9 +52,10 @@ int fnic_debugfs_init(void)`
`52`	`52`	`fc_trc_flag->fnic_trace = 2;`
`53`	`53`	`fc_trc_flag->fc_trace = 3;`
`54`	`54`	`fc_trc_flag->fc_clear = 4;`
	`55`	`+ return 0;`
`55`	`56`	`}`
`56`	`57`
`57`		`- return 0;`
	`58`	`+ return -ENOMEM;`
`58`	`59`	`}`
`59`	`60`
`60`	`61`	`/*`