Skip to content

Commit c3dd7de

Browse files
bcodding-rhTrond Myklebust
authored andcommitted
NFS: Fix sysfs server name memory leak
Free the formatted server index string after it has been duplicated by kobject_rename(). Fixes: 1c72511 ("NFS: add superblock sysfs entries") Reported-by: Alexander Aring <aahringo@redhat.com> Signed-off-by: Benjamin Coddington <bcodding@redhat.com> Tested-by: Ido Schimmel <idosch@nvidia.com> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
1 parent be2fd15 commit c3dd7de

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

fs/nfs/sysfs.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,8 +345,10 @@ void nfs_sysfs_move_sb_to_server(struct nfs_server *server)
345345
int ret = -ENOMEM;
346346

347347
s = kasprintf(GFP_KERNEL, "server-%d", server->s_sysfs_id);
348-
if (s)
348+
if (s) {
349349
ret = kobject_rename(&server->kobj, s);
350+
kfree(s);
351+
}
350352
if (ret < 0)
351353
pr_warn("NFS: rename sysfs %s failed (%d)\n",
352354
server->kobj.name, ret);

0 commit comments

Comments
 (0)