Skip to content

Commit be217b5

Browse files
nivedita76ksacilotto
authored andcommitted
x86/mm/mem_encrypt: Fix definition of PMD_FLAGS_DEC_WP
BugLink: https://bugs.launchpad.net/bugs/1910816 commit 29ac40c upstream. The PAT bit is in different locations for 4k and 2M/1G page table entries. Add a definition for _PAGE_LARGE_CACHE_MASK to represent the three caching bits (PWT, PCD, PAT), similar to _PAGE_CACHE_MASK for 4k pages, and use it in the definition of PMD_FLAGS_DEC_WP to get the correct PAT index for write-protected pages. Fixes: 6ebcb06 ("x86/mm: Add support to encrypt the kernel in-place") Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu> Signed-off-by: Borislav Petkov <bp@suse.de> Tested-by: Tom Lendacky <thomas.lendacky@amd.com> Cc: stable@vger.kernel.org Link: https://lkml.kernel.org/r/20201111160946.147341-1-nivedita@alum.mit.edu Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Kamal Mostafa <kamal@canonical.com> Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
1 parent 05db0fa commit be217b5

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

arch/x86/include/asm/pgtable_types.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ enum page_cache_mode {
147147
#endif
148148

149149
#define _PAGE_CACHE_MASK (_PAGE_PAT | _PAGE_PCD | _PAGE_PWT)
150+
#define _PAGE_LARGE_CACHE_MASK (_PAGE_PWT | _PAGE_PCD | _PAGE_PAT_LARGE)
150151
#define _PAGE_NOCACHE (cachemode2protval(_PAGE_CACHE_MODE_UC))
151152
#define _PAGE_CACHE_WP (cachemode2protval(_PAGE_CACHE_MODE_WP))
152153

arch/x86/mm/mem_encrypt_identity.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@
4545
#define PMD_FLAGS_LARGE (__PAGE_KERNEL_LARGE_EXEC & ~_PAGE_GLOBAL)
4646

4747
#define PMD_FLAGS_DEC PMD_FLAGS_LARGE
48-
#define PMD_FLAGS_DEC_WP ((PMD_FLAGS_DEC & ~_PAGE_CACHE_MASK) | \
49-
(_PAGE_PAT | _PAGE_PWT))
48+
#define PMD_FLAGS_DEC_WP ((PMD_FLAGS_DEC & ~_PAGE_LARGE_CACHE_MASK) | \
49+
(_PAGE_PAT_LARGE | _PAGE_PWT))
5050

5151
#define PMD_FLAGS_ENC (PMD_FLAGS_LARGE | _PAGE_ENC)
5252

0 commit comments

Comments
 (0)