Skip to content

Commit bae75d9

Browse files
DingHua Maksacilotto
authored andcommitted
regulator: axp20x: Fix DLDO2 voltage control register mask for AXP22x
BugLink: https://bugs.launchpad.net/bugs/1910822 commit 291de1d upstream. When I use the axp20x chip to power my SDIO device on the 5.4 kernel, the output voltage of DLDO2 is wrong. After comparing the register manual and source code of the chip, I found that the mask bit of the driver register of the port was wrong. I fixed this error by modifying the mask register of the source code. This error seems to be a copy error of the macro when writing the code. Now the voltage output of the DLDO2 port of axp20x is correct. My development environment is Allwinner A40I of arm architecture, and the kernel version is 5.4. Signed-off-by: DingHua Ma <dinghua.ma.sz@gmail.com> Reviewed-by: Chen-Yu Tsai <wens@csie.org> Cc: <stable@vger.kernel.org> Fixes: db4a555 ("regulator: axp20x: use defines for masks") Link: https://lore.kernel.org/r/20201201001000.22302-1-dinghua.ma.sz@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Kamal Mostafa <kamal@canonical.com> Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
1 parent 81082af commit bae75d9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/regulator/axp20x-regulator.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ static const struct regulator_desc axp22x_regulators[] = {
596596
AXP22X_DLDO1_V_OUT, AXP22X_DLDO1_V_OUT_MASK,
597597
AXP22X_PWR_OUT_CTRL2, AXP22X_PWR_OUT_DLDO1_MASK),
598598
AXP_DESC(AXP22X, DLDO2, "dldo2", "dldoin", 700, 3300, 100,
599-
AXP22X_DLDO2_V_OUT, AXP22X_PWR_OUT_DLDO2_MASK,
599+
AXP22X_DLDO2_V_OUT, AXP22X_DLDO2_V_OUT_MASK,
600600
AXP22X_PWR_OUT_CTRL2, AXP22X_PWR_OUT_DLDO2_MASK),
601601
AXP_DESC(AXP22X, DLDO3, "dldo3", "dldoin", 700, 3300, 100,
602602
AXP22X_DLDO3_V_OUT, AXP22X_DLDO3_V_OUT_MASK,

0 commit comments

Comments
 (0)