Skip to content

Commit 943aef2

Browse files
bcodding-rhTrond Myklebust
authored andcommitted
NFS: Open-code the nfs_kset kset_create_and_add()
In preparation to make objects below /sys/fs/nfs namespace aware, we need to define our own kobj_type for the nfs kset so that we can add the .child_ns_type member in a following patch. No functional change here, only the unrolling of kset_create_and_add(). Signed-off-by: Benjamin Coddington <bcodding@redhat.com> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
1 parent d5082ac commit 943aef2

File tree

1 file changed

+32
-2
lines changed

1 file changed

+32
-2
lines changed

fs/nfs/sysfs.c

Lines changed: 32 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,23 @@ static void nfs_netns_object_release(struct kobject *kobj)
2525
kfree(kobj);
2626
}
2727

28+
static void nfs_kset_release(struct kobject *kobj)
29+
{
30+
struct kset *kset = container_of(kobj, struct kset, kobj);
31+
kfree(kset);
32+
}
33+
2834
static const struct kobj_ns_type_operations *nfs_netns_object_child_ns_type(
2935
const struct kobject *kobj)
3036
{
3137
return &net_ns_type_operations;
3238
}
3339

40+
static struct kobj_type nfs_kset_type = {
41+
.release = nfs_kset_release,
42+
.sysfs_ops = &kobj_sysfs_ops,
43+
};
44+
3445
static struct kobj_type nfs_netns_object_type = {
3546
.release = nfs_netns_object_release,
3647
.sysfs_ops = &kobj_sysfs_ops,
@@ -55,13 +66,32 @@ static struct kobject *nfs_netns_object_alloc(const char *name,
5566

5667
int nfs_sysfs_init(void)
5768
{
58-
nfs_kset = kset_create_and_add("nfs", NULL, fs_kobj);
69+
int ret;
70+
71+
nfs_kset = kzalloc(sizeof(*nfs_kset), GFP_KERNEL);
5972
if (!nfs_kset)
6073
return -ENOMEM;
74+
75+
ret = kobject_set_name(&nfs_kset->kobj, "nfs");
76+
if (ret) {
77+
kfree(nfs_kset);
78+
return ret;
79+
}
80+
81+
nfs_kset->kobj.parent = fs_kobj;
82+
nfs_kset->kobj.ktype = &nfs_kset_type;
83+
nfs_kset->kobj.kset = NULL;
84+
85+
ret = kset_register(nfs_kset);
86+
if (ret) {
87+
kfree(nfs_kset);
88+
return ret;
89+
}
90+
6191
nfs_net_kobj = nfs_netns_object_alloc("net", nfs_kset, NULL);
6292
if (!nfs_net_kobj) {
6393
kset_unregister(nfs_kset);
64-
nfs_kset = NULL;
94+
kfree(nfs_kset);
6595
return -ENOMEM;
6696
}
6797
return 0;

0 commit comments

Comments
 (0)