regulator: avoid resolve_supply() infinite recursion

osctobe · broonie · commit 4b639e254d3d · 2020-11-13T14:21:25.000Z
When a regulator's name equals its supply's name the regulator_resolve_supply() recurses indefinitely. Add a check so that debugging the problem is easier. The "fixed" commit just exposed the problem. Fixes: aea6cb9 ("regulator: resolve supply after creating regulator") Cc: stable@vger.kernel.org Reported-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> Tested-by: Ahmad Fatoum <a.fatoum@pengutronix.de> # stpmic1 Link: https://lore.kernel.org/r/c6171057cfc0896f950c4d8cb82df0f9f1b89ad9.1605226675.git.mirq-linux@rere.qmqm.pl Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
@@ -1841,6 +1841,12 @@ static int regulator_resolve_supply(struct regulator_dev *rdev)
 		}
 	}
 
+	if (r == rdev) {
+		dev_err(dev, "Supply for %s (%s) resolved to itself\n",
+			rdev->desc->name, rdev->supply_name);
+		return -EINVAL;
+	}
+
 	/*
 	 * If the supply's parent device is not the same as the
 	 * regulator's parent device, then ensure the parent device

Original file line number	Diff line number	Diff line change
`@@ -1841,6 +1841,12 @@ static int regulator_resolve_supply(struct regulator_dev *rdev)`
`1841`	`1841`	`}`
`1842`	`1842`	`}`
`1843`	`1843`
	`1844`	`+ if (r == rdev) {`
	`1845`	`+ dev_err(dev, "Supply for %s (%s) resolved to itself\n",`
	`1846`	`+ rdev->desc->name, rdev->supply_name);`
	`1847`	`+ return -EINVAL;`
	`1848`	`+ }`
	`1849`	`+`
`1844`	`1850`	`/*`
`1845`	`1851`	`* If the supply's parent device is not the same as the`
`1846`	`1852`	`* regulator's parent device, then ensure the parent device`