Skip to content

Commit 1fd5394

Browse files
bcodding-rhamschuma-ntap
authored andcommitted
NFS: drop unused nfs_direct_req bytes_left
Now that we're calculating how large a remaining IO should be based on the current request's offset, we no longer need to track bytes_left on each struct nfs_direct_req. Drop the field, and clean up the direct request tracepoints. Signed-off-by: Benjamin Coddington <bcodding@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
1 parent 8a6291b commit 1fd5394

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

fs/nfs/direct.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,6 @@ static ssize_t nfs_direct_read_schedule_iovec(struct nfs_direct_req *dreq,
369369
bytes -= req_len;
370370
requested_bytes += req_len;
371371
pos += req_len;
372-
dreq->bytes_left -= req_len;
373372
}
374373
nfs_direct_release_pages(pagevec, npages);
375374
kvfree(pagevec);
@@ -441,7 +440,7 @@ ssize_t nfs_file_direct_read(struct kiocb *iocb, struct iov_iter *iter,
441440
goto out;
442441

443442
dreq->inode = inode;
444-
dreq->bytes_left = dreq->max_count = count;
443+
dreq->max_count = count;
445444
dreq->io_start = iocb->ki_pos;
446445
dreq->ctx = get_nfs_open_context(nfs_file_open_context(iocb->ki_filp));
447446
l_ctx = nfs_get_lock_context(dreq->ctx);
@@ -874,7 +873,6 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq,
874873
bytes -= req_len;
875874
requested_bytes += req_len;
876875
pos += req_len;
877-
dreq->bytes_left -= req_len;
878876

879877
if (defer) {
880878
nfs_mark_request_commit(req, NULL, &cinfo, 0);
@@ -981,7 +979,7 @@ ssize_t nfs_file_direct_write(struct kiocb *iocb, struct iov_iter *iter,
981979
goto out;
982980

983981
dreq->inode = inode;
984-
dreq->bytes_left = dreq->max_count = count;
982+
dreq->max_count = count;
985983
dreq->io_start = pos;
986984
dreq->ctx = get_nfs_open_context(nfs_file_open_context(iocb->ki_filp));
987985
l_ctx = nfs_get_lock_context(dreq->ctx);

fs/nfs/internal.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -936,7 +936,6 @@ struct nfs_direct_req {
936936
loff_t io_start; /* Start offset for I/O */
937937
ssize_t count, /* bytes actually processed */
938938
max_count, /* max expected count */
939-
bytes_left, /* bytes left to be sent */
940939
error; /* any reported error */
941940
struct completion completion; /* wait for i/o completion */
942941

fs/nfs/nfstrace.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1545,7 +1545,6 @@ DECLARE_EVENT_CLASS(nfs_direct_req_class,
15451545
__field(u32, fhandle)
15461546
__field(loff_t, offset)
15471547
__field(ssize_t, count)
1548-
__field(ssize_t, bytes_left)
15491548
__field(ssize_t, error)
15501549
__field(int, flags)
15511550
),
@@ -1560,19 +1559,18 @@ DECLARE_EVENT_CLASS(nfs_direct_req_class,
15601559
__entry->fhandle = nfs_fhandle_hash(fh);
15611560
__entry->offset = dreq->io_start;
15621561
__entry->count = dreq->count;
1563-
__entry->bytes_left = dreq->bytes_left;
15641562
__entry->error = dreq->error;
15651563
__entry->flags = dreq->flags;
15661564
),
15671565

15681566
TP_printk(
15691567
"error=%zd fileid=%02x:%02x:%llu fhandle=0x%08x "
1570-
"offset=%lld count=%zd bytes_left=%zd flags=%s",
1568+
"offset=%lld count=%zd flags=%s",
15711569
__entry->error, MAJOR(__entry->dev),
15721570
MINOR(__entry->dev),
15731571
(unsigned long long)__entry->fileid,
15741572
__entry->fhandle, __entry->offset,
1575-
__entry->count, __entry->bytes_left,
1573+
__entry->count,
15761574
nfs_show_direct_req_flags(__entry->flags)
15771575
)
15781576
);

0 commit comments

Comments
 (0)