blocklayoutdriver: Fix reference leak of pnfs_device_node

bcodding-rh · amschuma-ntap · commit 1530827b9002 · 2024-01-04T10:47:56.000-05:00
The error path for blocklayout's device lookup is missing a reference drop for the case where a lookup finds the device, but the device is marked with NFS_DEVICEID_UNAVAILABLE. Fixes: b3dce6a ("pnfs/blocklayout: handle transient devices") Signed-off-by: Benjamin Coddington <bcodding@redhat.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
diff --git a/fs/nfs/blocklayout/blocklayout.c b/fs/nfs/blocklayout/blocklayout.c
@@ -580,6 +580,8 @@ bl_find_get_deviceid(struct nfs_server *server,
 		nfs4_delete_deviceid(node->ld, node->nfs_client, id);
 		goto retry;
 	}
+
+	nfs4_put_deviceid_node(node);
 	return ERR_PTR(-ENODEV);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -580,6 +580,8 @@ bl_find_get_deviceid(struct nfs_server *server,`
`580`	`580`	`nfs4_delete_deviceid(node->ld, node->nfs_client, id);`
`581`	`581`	`goto retry;`
`582`	`582`	`}`
	`583`	`+`
	`584`	`+ nfs4_put_deviceid_node(node);`
`583`	`585`	`return ERR_PTR(-ENODEV);`
`584`	`586`	`}`
`585`	`587`