Skip to content

Commit df0d6f7

Browse files
jefstathdavem330
authored andcommitted
lan78xx: Limit number of driver warning messages
Device removal can result in a large burst of driver warning messages (20 - 30) sent to the kernel log. Most of these are register read/write failures. This change limits the rate at which these messages are emitted. Signed-off-by: John Efstathiades <john.efstathiades@pebblebay.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 77dfff5 commit df0d6f7

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/net/usb/lan78xx.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ static int lan78xx_read_reg(struct lan78xx_net *dev, u32 index, u32 *data)
462462
if (likely(ret >= 0)) {
463463
le32_to_cpus(buf);
464464
*data = *buf;
465-
} else {
465+
} else if (net_ratelimit()) {
466466
netdev_warn(dev->net,
467467
"Failed to read register index 0x%08x. ret = %d",
468468
index, ret);
@@ -492,7 +492,8 @@ static int lan78xx_write_reg(struct lan78xx_net *dev, u32 index, u32 data)
492492
USB_VENDOR_REQUEST_WRITE_REGISTER,
493493
USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
494494
0, index, buf, 4, USB_CTRL_SET_TIMEOUT);
495-
if (unlikely(ret < 0)) {
495+
if (unlikely(ret < 0) &&
496+
net_ratelimit()) {
496497
netdev_warn(dev->net,
497498
"Failed to write register index 0x%08x. ret = %d",
498499
index, ret);

0 commit comments

Comments
 (0)