Skip to content

Commit 4330869

Browse files
committed
crypto: s390/paes - Fix module aliases
The paes_s390 module didn't declare the correct aliases for the algorithms that it registered. Instead it declared an alias for the non-existent paes algorithm. The Crypto API will eventually try to load the paes algorithm, to construct the cbc(paes) instance. But because the module does not actually contain a "paes" algorithm, this will fail. Previously this failure was hidden and the the cbc(paes) lookup will be retried. This was fixed recently, thus exposing the buggy alias in paes_s390. Replace the bogus paes alias with aliases for the actual algorithms. Reported-by: Ingo Franzki <ifranzki@linux.ibm.com> Fixes: e7a4142 ("crypto: api - Fix generic algorithm self-test races") Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Tested-by: Ingo Franzki <ifranzki@linux.ibm.com> Reviewed-by: Ingo Franzki <ifranzki@linux.ibm.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
1 parent 5124bc9 commit 4330869

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

arch/s390/crypto/paes_s390.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -802,7 +802,10 @@ static int __init paes_s390_init(void)
802802
module_init(paes_s390_init);
803803
module_exit(paes_s390_fini);
804804

805-
MODULE_ALIAS_CRYPTO("paes");
805+
MODULE_ALIAS_CRYPTO("ecb(paes)");
806+
MODULE_ALIAS_CRYPTO("cbc(paes)");
807+
MODULE_ALIAS_CRYPTO("ctr(paes)");
808+
MODULE_ALIAS_CRYPTO("xts(paes)");
806809

807810
MODULE_DESCRIPTION("Rijndael (AES) Cipher Algorithm with protected keys");
808811
MODULE_LICENSE("GPL");

0 commit comments

Comments
 (0)