Skip to content

Commit 1ba44a1

Browse files
Philippe Reynesdavem330
authored andcommitted
net: ethernet: dnet: use phy_ethtool_{get|set}_link_ksettings
There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes <tremyfr@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 958974f commit 1ba44a1

File tree

1 file changed

+2
-22
lines changed

1 file changed

+2
-22
lines changed

drivers/net/ethernet/dnet.c

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -730,26 +730,6 @@ static struct net_device_stats *dnet_get_stats(struct net_device *dev)
730730
return nstat;
731731
}
732732

733-
static int dnet_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
734-
{
735-
struct phy_device *phydev = dev->phydev;
736-
737-
if (!phydev)
738-
return -ENODEV;
739-
740-
return phy_ethtool_gset(phydev, cmd);
741-
}
742-
743-
static int dnet_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
744-
{
745-
struct phy_device *phydev = dev->phydev;
746-
747-
if (!phydev)
748-
return -ENODEV;
749-
750-
return phy_ethtool_sset(phydev, cmd);
751-
}
752-
753733
static int dnet_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
754734
{
755735
struct phy_device *phydev = dev->phydev;
@@ -772,11 +752,11 @@ static void dnet_get_drvinfo(struct net_device *dev,
772752
}
773753

774754
static const struct ethtool_ops dnet_ethtool_ops = {
775-
.get_settings = dnet_get_settings,
776-
.set_settings = dnet_set_settings,
777755
.get_drvinfo = dnet_get_drvinfo,
778756
.get_link = ethtool_op_get_link,
779757
.get_ts_info = ethtool_op_get_ts_info,
758+
.get_link_ksettings = phy_ethtool_get_link_ksettings,
759+
.set_link_ksettings = phy_ethtool_set_link_ksettings,
780760
};
781761

782762
static const struct net_device_ops dnet_netdev_ops = {

0 commit comments

Comments
 (0)