Skip to content

Commit 0684f29

Browse files
committed
netlink: specs: correct types of legacy arrays
ethtool has some attrs which dump multiple scalars into an attribute. The spec currently expects one attr per entry. Fixes: a353318 ("tools: ynl: populate most of the ethtool spec") Acked-by: Stanislav Fomichev <sdf@google.com> Link: https://lore.kernel.org/r/20230526220653.65538-1-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 36936a5 commit 0684f29

File tree

1 file changed

+8
-24
lines changed

1 file changed

+8
-24
lines changed

Documentation/netlink/specs/ethtool.yaml

Lines changed: 8 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -60,22 +60,6 @@ attribute-sets:
6060
type: nest
6161
nested-attributes: bitset-bits
6262

63-
-
64-
name: u64-array
65-
attributes:
66-
-
67-
name: u64
68-
type: nest
69-
multi-attr: true
70-
nested-attributes: u64
71-
-
72-
name: s32-array
73-
attributes:
74-
-
75-
name: s32
76-
type: nest
77-
multi-attr: true
78-
nested-attributes: s32
7963
-
8064
name: string
8165
attributes:
@@ -705,16 +689,16 @@ attribute-sets:
705689
type: u8
706690
-
707691
name: corrected
708-
type: nest
709-
nested-attributes: u64-array
692+
type: binary
693+
sub-type: u64
710694
-
711695
name: uncorr
712-
type: nest
713-
nested-attributes: u64-array
696+
type: binary
697+
sub-type: u64
714698
-
715699
name: corr-bits
716-
type: nest
717-
nested-attributes: u64-array
700+
type: binary
701+
sub-type: u64
718702
-
719703
name: fec
720704
attributes:
@@ -827,8 +811,8 @@ attribute-sets:
827811
type: u32
828812
-
829813
name: index
830-
type: nest
831-
nested-attributes: s32-array
814+
type: binary
815+
sub-type: s32
832816
-
833817
name: module
834818
attributes:

0 commit comments

Comments
 (0)