Skip to content

Commit aea52f9

Browse files
larsclausensmb49
authored andcommitted
iio: itg3200: Call iio_trigger_notify_done() on error
BugLink: https://bugs.launchpad.net/bugs/1957007 commit 67fe295 upstream. IIO trigger handlers must call iio_trigger_notify_done() when done. This must be done even when an error occurred. Otherwise the trigger will be seen as busy indefinitely and the trigger handler will never be called again. The itg3200 driver neglects to call iio_trigger_notify_done() when there is an error reading the gyro data. Fix this by making sure that iio_trigger_notify_done() is included in the error exit path. Fixes: 9dbf091 ("iio: gyro: Add itg3200") Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Link: https://lore.kernel.org/r/20211101144055.13858-1-lars@metafoo.de Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Kamal Mostafa <kamal@canonical.com> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
1 parent 7dc8ea1 commit aea52f9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/iio/gyro/itg3200_buffer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,9 @@ static irqreturn_t itg3200_trigger_handler(int irq, void *p)
6161

6262
iio_push_to_buffers_with_timestamp(indio_dev, &scan, pf->timestamp);
6363

64+
error_ret:
6465
iio_trigger_notify_done(indio_dev->trig);
6566

66-
error_ret:
6767
return IRQ_HANDLED;
6868
}
6969

0 commit comments

Comments
 (0)