Skip to content

Commit 8c1beb9

Browse files
author
Steve French
committed
cifs: minor clarification in comments
Clarify meaning (in comments) meaning of various options for debug messages in cifs.ko. Also fixed trivial formatting/style issue with previous patch. Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent f80eaed commit 8c1beb9

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

fs/cifs/cifs_debug.h

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,18 @@ extern int cifsFYI;
4747
*/
4848
#ifdef CONFIG_CIFS_DEBUG
4949

50+
51+
/*
52+
* When adding tracepoints and debug messages we have various choices.
53+
* Some considerations:
54+
*
55+
* Use cifs_dbg(VFS, ...) for things we always want logged, and the user to see
56+
* cifs_info(...) slightly less important, admin can filter via loglevel > 6
57+
* cifs_dbg(FYI, ...) minor debugging messages, off by default
58+
* trace_smb3_* ftrace functions are preferred for complex debug messages
59+
* intended for developers or experienced admins, off by default
60+
*/
61+
5062
/* Information level messages, minor events */
5163
#define cifs_info_func(ratefunc, fmt, ...) \
5264
do { \

fs/cifs/cifsfs.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -717,8 +717,10 @@ cifs_smb3_do_mount(struct file_system_type *fs_type,
717717
struct cifs_mnt_data mnt_data;
718718
struct dentry *root;
719719

720-
/* Prints in Kernel / CIFS log the attempted mount operation *
721-
* IF CIFS_DEBUG && cifs_FYI */
720+
/*
721+
* Prints in Kernel / CIFS log the attempted mount operation
722+
* If CIFS_DEBUG && cifs_FYI
723+
*/
722724
if (cifsFYI)
723725
cifs_dbg(FYI, "Devname: %s flags: %d\n", dev_name, flags);
724726
else

0 commit comments

Comments
 (0)