Skip to content

Commit 5b4eac2

Browse files
gscuismb49
authored andcommitted
phy: tegra: xusb: Add missing tegra_xusb_port_unregister for usb2_port and ulpi_port
BugLink: https://bugs.launchpad.net/bugs/2025095 [ Upstream commit e024854 ] The tegra_xusb_port_unregister should be called when usb2_port and ulpi_port map fails in tegra_xusb_add_usb2_port() or in tegra_xusb_add_ulpi_port(), fix it. Fixes: 53d2a71 ("phy: Add Tegra XUSB pad controller support") Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> Acked-by: Thierry Reding <treding@nvidia.com> Link: https://lore.kernel.org/r/20221129111634.1547747-1-cuigaosheng1@huawei.com Signed-off-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Kamal Mostafa <kamal@canonical.com> Signed-off-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>
1 parent 52ba320 commit 5b4eac2

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/phy/tegra/xusb.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -781,6 +781,7 @@ static int tegra_xusb_add_usb2_port(struct tegra_xusb_padctl *padctl,
781781
usb2->base.lane = usb2->base.ops->map(&usb2->base);
782782
if (IS_ERR(usb2->base.lane)) {
783783
err = PTR_ERR(usb2->base.lane);
784+
tegra_xusb_port_unregister(&usb2->base);
784785
goto out;
785786
}
786787

@@ -847,6 +848,7 @@ static int tegra_xusb_add_ulpi_port(struct tegra_xusb_padctl *padctl,
847848
ulpi->base.lane = ulpi->base.ops->map(&ulpi->base);
848849
if (IS_ERR(ulpi->base.lane)) {
849850
err = PTR_ERR(ulpi->base.lane);
851+
tegra_xusb_port_unregister(&ulpi->base);
850852
goto out;
851853
}
852854

0 commit comments

Comments
 (0)