Skip to content

Commit fd954cc

Browse files
apconolePaolo Abeni
authored andcommitted
openvswitch: switch from WARN to pr_warn
As noted by Paolo Abeni, pr_warn doesn't generate any splat and can still preserve the warning to the user that feature downgrade occurred. We likely cannot introduce other kinds of checks / enforcement here because syzbot can generate different genl versions to the datapath. Reported-by: syzbot+31cde0bef4bbf8ba2d86@syzkaller.appspotmail.com Fixes: 44da5ae ("openvswitch: Drop user features if old user space attempted to create datapath") Cc: Thomas Graf <tgraf@suug.ch> Signed-off-by: Aaron Conole <aconole@redhat.com> Acked-by: Ilya Maximets <i.maximets@ovn.org> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent e2badb4 commit fd954cc

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

net/openvswitch/datapath.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1616,7 +1616,8 @@ static void ovs_dp_reset_user_features(struct sk_buff *skb,
16161616
if (IS_ERR(dp))
16171617
return;
16181618

1619-
WARN(dp->user_features, "Dropping previously announced user features\n");
1619+
pr_warn("%s: Dropping previously announced user features\n",
1620+
ovs_dp_name(dp));
16201621
dp->user_features = 0;
16211622
}
16221623

0 commit comments

Comments
 (0)