Skip to content

Commit f6da8bd

Browse files
committed
Merge tag 'char-misc-5.7-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
Pull char/misc driver fixes from Greg KH: "Here are 4 small misc driver fixes for 5.7-rc3: - mei driver fix - interconnect driver fix - two fpga driver fixes All have been in linux-next with no reported issues" * tag 'char-misc-5.7-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: interconnect: qcom: Fix uninitialized tcs_cmd::wait mei: me: fix irq number stored in hw struct fpga: dfl: pci: fix return value of cci_pci_sriov_configure fpga: zynq: Remove clk_get error message for probe defer
2 parents edf17b2 + 9c0c54a commit f6da8bd

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

drivers/fpga/dfl-pci.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,11 +248,13 @@ static int cci_pci_sriov_configure(struct pci_dev *pcidev, int num_vfs)
248248
return ret;
249249

250250
ret = pci_enable_sriov(pcidev, num_vfs);
251-
if (ret)
251+
if (ret) {
252252
dfl_fpga_cdev_config_ports_pf(cdev);
253+
return ret;
254+
}
253255
}
254256

255-
return ret;
257+
return num_vfs;
256258
}
257259

258260
static void cci_pci_remove(struct pci_dev *pcidev)

drivers/fpga/zynq-fpga.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,8 @@ static int zynq_fpga_probe(struct platform_device *pdev)
583583

584584
priv->clk = devm_clk_get(dev, "ref_clk");
585585
if (IS_ERR(priv->clk)) {
586-
dev_err(dev, "input clock not found\n");
586+
if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
587+
dev_err(dev, "input clock not found\n");
587588
return PTR_ERR(priv->clk);
588589
}
589590

drivers/interconnect/qcom/bcm-voter.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,8 @@ static inline void tcs_cmd_gen(struct tcs_cmd *cmd, u64 vote_x, u64 vote_y,
9696
if (!cmd)
9797
return;
9898

99+
memset(cmd, 0, sizeof(*cmd));
100+
99101
if (vote_x == 0 && vote_y == 0)
100102
valid = false;
101103

@@ -112,8 +114,7 @@ static inline void tcs_cmd_gen(struct tcs_cmd *cmd, u64 vote_x, u64 vote_y,
112114
* Set the wait for completion flag on command that need to be completed
113115
* before the next command.
114116
*/
115-
if (commit)
116-
cmd->wait = true;
117+
cmd->wait = commit;
117118
}
118119

119120
static void tcs_list_gen(struct list_head *bcm_list, int bucket,

drivers/misc/mei/pci-me.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,11 +203,12 @@ static int mei_me_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
203203
}
204204
hw = to_me_hw(dev);
205205
hw->mem_addr = pcim_iomap_table(pdev)[0];
206-
hw->irq = pdev->irq;
207206
hw->read_fws = mei_me_read_fws;
208207

209208
pci_enable_msi(pdev);
210209

210+
hw->irq = pdev->irq;
211+
211212
/* request and enable interrupt */
212213
irqflags = pci_dev_msi_enabled(pdev) ? IRQF_ONESHOT : IRQF_SHARED;
213214

0 commit comments

Comments
 (0)